Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reduced dependencies within num #353

Merged
merged 1 commit into from Aug 28, 2021
Merged

Reduced dependencies within num #353

merged 1 commit into from Aug 28, 2021

Conversation

jorgecarleitao
Copy link
Owner

num is a "metacrate" with 5 crates, but we only use num-traits. This PR migrates from one to the other.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 28, 2021
@jorgecarleitao jorgecarleitao changed the title Reduced dependencies Reduced dependencies within num Aug 28, 2021
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #353 (a3f1391) into main (87aa617) will decrease coverage by 0.67%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   81.01%   80.33%   -0.68%     
==========================================
  Files         326      326              
  Lines       21172    21275     +103     
==========================================
- Hits        17152    17091      -61     
- Misses       4020     4184     +164     
Impacted Files Coverage Δ
src/array/dictionary/mod.rs 72.50% <ø> (ø)
src/array/specification.rs 70.00% <ø> (ø)
src/compute/arithmetics/basic/add.rs 94.83% <ø> (ø)
src/compute/arithmetics/basic/div.rs 96.52% <ø> (ø)
src/compute/arithmetics/basic/mul.rs 94.83% <ø> (ø)
src/compute/arithmetics/basic/pow.rs 100.00% <ø> (ø)
src/compute/arithmetics/basic/rem.rs 96.52% <ø> (ø)
src/compute/arithmetics/basic/sub.rs 94.83% <ø> (ø)
src/compute/arithmetics/mod.rs 51.12% <ø> (ø)
src/compute/arithmetics/time.rs 97.48% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87aa617...a3f1391. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 6fa9677 into main Aug 28, 2021
@jorgecarleitao jorgecarleitao deleted the dependencies branch August 28, 2021 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant