Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error writing dictionary extension to IPC #397

Merged
merged 1 commit into from Sep 12, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Sep 11, 2021

Dictionary extensions are tricky in that they are represented by a single Field in IPC, but are represented as Dictionary(Extension()) as a DataType, which requires some custom code to handle correctly. This PR does this

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Sep 11, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #397 (30bada9) into main (f326fed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files         347      347           
  Lines       21991    21996    +5     
=======================================
+ Hits        17842    17847    +5     
  Misses       4149     4149           
Impacted Files Coverage Δ
src/io/ipc/convert.rs 94.95% <100.00%> (+0.04%) ⬆️
tests/it/io/ipc/write/file.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f326fed...30bada9. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Fixed error in writing dictionary with extensions to IPC Fixed error writing dictionary extension to IPC Sep 11, 2021
@jorgecarleitao jorgecarleitao merged commit 9fa21bd into main Sep 12, 2021
@jorgecarleitao jorgecarleitao deleted the fix_extension_write branch September 12, 2021 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant