Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Changed IPC FileWriter to own the writer. #420

Merged
merged 3 commits into from Sep 22, 2021

Conversation

yjshen
Copy link
Contributor

@yjshen yjshen commented Sep 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #420 (b5a9b09) into main (06c45f8) will decrease coverage by 0.16%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   80.96%   80.80%   -0.17%     
==========================================
  Files         347      372      +25     
  Lines       22201    22642     +441     
==========================================
+ Hits        17975    18295     +320     
- Misses       4226     4347     +121     
Impacted Files Coverage Δ
src/io/ipc/write/writer.rs 83.33% <75.00%> (+3.00%) ⬆️
tests/it/io/ipc/write/file.rs 100.00% <100.00%> (ø)
src/compute/arithmetics/time.rs 47.05% <0.00%> (-50.43%) ⬇️
src/compute/arithmetics/mod.rs 23.07% <0.00%> (-28.06%) ⬇️
src/compute/contains.rs 34.31% <0.00%> (-16.43%) ⬇️
src/compute/take/mod.rs 76.47% <0.00%> (-16.22%) ⬇️
src/compute/aggregate/memory.rs 25.00% <0.00%> (-15.00%) ⬇️
src/compute/arithmetics/decimal/div.rs 79.01% <0.00%> (-13.06%) ⬇️
src/compute/arithmetics/decimal/mul.rs 79.01% <0.00%> (-13.03%) ⬇️
src/compute/aggregate/min_max.rs 66.66% <0.00%> (-12.48%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c45f8...b5a9b09. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very clean and very easy to follow 💯

Left two comments where I am not following the rational and would like some help to understand.

src/io/ipc/write/writer.rs Outdated Show resolved Hide resolved
src/io/ipc/write/writer.rs Outdated Show resolved Hide resolved
src/io/ipc/write/writer.rs Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title Own writer in IPC FileWriter Changed IPC FileWriter to own the writer. Sep 17, 2021
@jorgecarleitao jorgecarleitao merged commit 4c2f4dc into jorgecarleitao:main Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants