Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Move tests from src/compute/ to tests/ #423

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

VasanthakumarV
Copy link
Contributor

Closes #409

Unit tests from the following files were not moved, because they referenced private functions,

./src/compute/comparison/primitive.rs
./src/compute/comparison/binary.rs
./src/compute/comparison/utf8.rs
./src/compute/comparison/boolean.rs
./src/compute/arithmetics/decimal/mod.rs
./src/compute/take/utf8.rs
./src/compute/take/boolean.rs
./src/compute/take/list.rs
./src/compute/sort/primitive/sort.rs
./src/compute/sort/primitive/indices.rs

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #423 (1aa902f) into main (aee8124) will increase coverage by 0.01%.
The diff coverage is 99.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   80.78%   80.80%   +0.01%     
==========================================
  Files         353      372      +19     
  Lines       22600    22648      +48     
==========================================
+ Hits        18257    18300      +43     
- Misses       4343     4348       +5     
Impacted Files Coverage Δ
src/compute/aggregate/memory.rs 25.00% <ø> (-15.00%) ⬇️
src/compute/aggregate/min_max.rs 66.66% <ø> (-12.48%) ⬇️
src/compute/aggregate/sum.rs 66.66% <ø> (-10.72%) ⬇️
src/compute/arithmetics/basic/add.rs 85.18% <ø> (-9.66%) ⬇️
src/compute/arithmetics/basic/div.rs 92.30% <ø> (-4.22%) ⬇️
src/compute/arithmetics/basic/mul.rs 85.18% <ø> (-9.66%) ⬇️
src/compute/arithmetics/basic/pow.rs 100.00% <ø> (ø)
src/compute/arithmetics/basic/rem.rs 92.30% <ø> (-4.22%) ⬇️
src/compute/arithmetics/basic/sub.rs 85.18% <ø> (-9.66%) ⬇️
src/compute/arithmetics/decimal/add.rs 80.82% <ø> (-10.46%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee8124...1aa902f. Read the comment docs.

@VasanthakumarV
Copy link
Contributor Author

Not sure why the docs pipeline failed, locally I am able to run cargo doc --lib --features full --no-deps (1.57.0-nightly),
I saw an issue for something similar opened today, but I also see that other pipelines here have run successfully.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@jorgecarleitao jorgecarleitao merged commit 2e19615 into jorgecarleitao:main Sep 19, 2021
@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests from src/compute to tests/
2 participants