Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allowed accessing validity without importing Array #432

Merged
merged 1 commit into from Sep 26, 2021

Conversation

jorgecarleitao
Copy link
Owner

This avoids importing Array just to access the validity bitmap for structs implementing Array.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 20, 2021
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #432 (d454fd2) into main (db92910) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   80.64%   80.66%   +0.01%     
==========================================
  Files         372      372              
  Lines       22691    22709      +18     
==========================================
+ Hits        18300    18318      +18     
  Misses       4391     4391              
Impacted Files Coverage Δ
src/compute/utils.rs 92.85% <ø> (ø)
src/array/boolean/mod.rs 68.62% <25.00%> (+1.28%) ⬆️
src/array/list/mod.rs 70.45% <65.00%> (+0.68%) ⬆️
src/array/binary/mod.rs 78.37% <100.00%> (+0.60%) ⬆️
src/array/dictionary/mod.rs 46.66% <100.00%> (+1.83%) ⬆️
src/array/fixed_size_binary/mod.rs 46.75% <100.00%> (+1.41%) ⬆️
src/array/fixed_size_list/mod.rs 52.77% <100.00%> (+1.34%) ⬆️
src/array/primitive/mod.rs 79.03% <100.00%> (+0.69%) ⬆️
src/array/struct_.rs 35.48% <100.00%> (+1.41%) ⬆️
src/array/utf8/mod.rs 81.81% <100.00%> (+0.48%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db92910...d454fd2. Read the comment docs.

@jorgecarleitao jorgecarleitao force-pushed the simpler_validity branch 2 times, most recently from 371a369 to 96fde01 Compare September 25, 2021 10:16
@jorgecarleitao jorgecarleitao marked this pull request as ready for review September 25, 2021 10:19
@jorgecarleitao jorgecarleitao changed the title Simplify accessing validity Allowed accessing validity without importing Array Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant