Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed assert from MutableBuffer::set_len #443

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

ritchie46
Copy link
Collaborator

@ritchie46 ritchie46 commented Sep 23, 2021

This follows the same implementation as the one followed by std::Vec.

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #443 (0194754) into main (688e979) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files         372      372           
  Lines       22637    22637           
=======================================
  Hits        18286    18286           
  Misses       4351     4351           
Impacted Files Coverage Δ
src/buffer/mutable.rs 88.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688e979...0194754. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title use debug_assert and update invariant docs of MutableBuffer::set_len Remove assert from MutableBuffer::set_len Sep 23, 2021
@jorgecarleitao jorgecarleitao merged commit 885e6c1 into jorgecarleitao:main Sep 23, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 23, 2021
@jorgecarleitao jorgecarleitao changed the title Remove assert from MutableBuffer::set_len Removed assert from MutableBuffer::set_len Sep 23, 2021
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants