Added MutableArray::as_box

[sd2k]

This basically just changes the impls of as_arc to as_box and uses
the From<Box<T>> for Arc<T> impl to provide a default implementation
for as_arc.

Closes #447.

[sd2k]

Just wondering, is there a reason that the as_arc method wasn't a (consuming) into_arc method?

[jorgecarleitao]

Thank you for this PR 🙇 Looks great and ready to go.

Just wondering, is there a reason that the as_arc method wasn't a (consuming) into_arc method?

Great question :)

For a trait to be a trait object, it cannot be Sized. Any method that consumes self (and not &mut self) makes the trait automatically Sized (because fn a(self) requires knowing the size of Self to make it to a registry). So, we either have into_arc(self) and not a trait object, or a trait object and as_arc(&mut self). Since we really need the trait object here, we make it a trait object (and use as_arc).

But yes, you are right that into_arc is what makes sense here.

[sd2k]

Ah of course, I'd forgotten we needed object safety 😅 Kind of fundamental hehe. Thanks!

[codecov]

Codecov Report

Merging #450 (f5dbdb8) into main (885e6c1) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   80.77%   80.49%   -0.29%     
==========================================
  Files         372      372              
  Lines       22637    22735      +98     
==========================================
+ Hits        18286    18300      +14     
- Misses       4351     4435      +84     

Impacted Files	Coverage Δ
src/array/binary/mutable.rs	63.35% <0.00%> (-2.06%)	⬇️
src/array/boolean/mutable.rs	85.23% <0.00%> (-2.96%)	⬇️
src/array/dictionary/mutable.rs	76.66% <0.00%> (-5.48%)	⬇️
src/array/fixed_size_binary/mutable.rs	71.76% <0.00%> (-4.49%)	⬇️
src/array/fixed_size_list/mutable.rs	36.84% <0.00%> (-3.55%)	⬇️
src/array/list/mutable.rs	70.96% <0.00%> (-4.90%)	⬇️
src/array/mod.rs	54.62% <0.00%> (-4.36%)	⬇️
src/array/primitive/mutable.rs	86.19% <0.00%> (-2.11%)	⬇️
src/array/utf8/mutable.rs	87.70% <0.00%> (-2.22%)	⬇️
src/array/dictionary/mod.rs	44.82% <0.00%> (-14.00%)	⬇️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885e6c1...f5dbdb8. Read the comment docs.