Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added checked_negate and wrapping_negate for PrimitiveArray #506

Merged
merged 3 commits into from
Oct 9, 2021

Conversation

yjhmelody
Copy link
Contributor

Close #465.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #506 (e72da96) into main (9163616) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   80.18%   80.17%   -0.01%     
==========================================
  Files         381      381              
  Lines       23659    23659              
==========================================
- Hits        18970    18968       -2     
- Misses       4689     4691       +2     
Impacted Files Coverage Δ
src/compute/arithmetics/mod.rs 24.70% <ø> (ø)
src/compute/arithmetics/time.rs 44.89% <0.00%> (-2.05%) ⬇️
src/io/ipc/write/common.rs 75.64% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9163616...e72da96. Read the comment docs.

@yjhmelody yjhmelody marked this pull request as ready for review October 8, 2021 08:12
@jorgecarleitao jorgecarleitao added the feature A new feature label Oct 9, 2021
@jorgecarleitao jorgecarleitao changed the title feat: add checked_negate and wrapping_negate for primitive array Added checked_negate and wrapping_negate for PrimitiveArray Oct 9, 2021
@jorgecarleitao jorgecarleitao merged commit e77d4e1 into jorgecarleitao:main Oct 9, 2021
@yjhmelody yjhmelody deleted the arith-neg branch October 9, 2021 04:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrow2::compute::arithmetics::negate will panic if use i32::MIN
2 participants