Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Change IPC FileReader to own the underlying reader #518

Merged
merged 1 commit into from Oct 10, 2021

Conversation

blakesmith
Copy link
Contributor

Closes: #514

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #518 (cfae03e) into main (e77d4e1) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   80.18%   80.17%   -0.01%     
==========================================
  Files         381      381              
  Lines       23665    23667       +2     
==========================================
  Hits        18975    18975              
- Misses       4690     4692       +2     
Impacted Files Coverage Δ
src/io/ipc/read/reader.rs 82.20% <33.33%> (-1.42%) ⬇️
tests/it/io/ipc/read/file.rs 100.00% <100.00%> (ø)
tests/it/io/ipc/write/file.rs 100.00% <100.00%> (ø)
src/io/avro/read/schema.rs 54.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77d4e1...cfae03e. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless 💯. Thanks a lot, @blakesmith !

@jorgecarleitao jorgecarleitao merged commit 6462c83 into jorgecarleitao:main Oct 10, 2021
@blakesmith
Copy link
Contributor Author

Awesome! Thank you so much @jorgecarleitao!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileReader doesn't own underlying reader?
2 participants