Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added fmt and clippy checks to CI. #522

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

xudong963
Copy link
Contributor

Close #520

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Oct 10, 2021
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #522 (cd2828a) into main (25ddb0d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   80.17%   80.19%   +0.01%     
==========================================
  Files         381      381              
  Lines       23690    23730      +40     
==========================================
+ Hits        18994    19030      +36     
- Misses       4696     4700       +4     
Impacted Files Coverage Δ
src/datatypes/field.rs 25.00% <ø> (-4.14%) ⬇️
src/io/csv/write/serialize.rs 52.58% <ø> (ø)
src/io/ipc/convert.rs 94.87% <ø> (ø)
src/io/ipc/endianess.rs 25.00% <ø> (ø)
src/io/ipc/read/read_basic.rs 88.50% <ø> (ø)
src/io/ipc/write/common.rs 75.64% <ø> (ø)
src/io/ipc/write/serialize.rs 96.55% <ø> (ø)
src/datatypes/mod.rs 74.64% <100.00%> (+2.77%) ⬆️
src/io/parquet/write/dictionary.rs 70.37% <0.00%> (-2.36%) ⬇️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (-1.50%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ddb0d...cd2828a. Read the comment docs.

@xudong963
Copy link
Contributor Author

delete dead code, is_native_little_endian also seems to be never used

@jorgecarleitao
Copy link
Owner

We should use ´--full´ feature here: that function is used in io_ipc (we could also move it there).

@xudong963
Copy link
Contributor Author

with_match_dictionary_key_type also need a suitable placement, how do you think about it @jorgecarleitao

@houqp
Copy link
Collaborator

houqp commented Oct 10, 2021

that macro is used in various compute and io modules. try changing the clippy run to cargo clippy --all --features=full -- -D warnings as @jorgecarleitao suggested.

@jorgecarleitao jorgecarleitao changed the title enhance fmt and clippy Added fmt and clippy checks to CI. Oct 12, 2021
@jorgecarleitao jorgecarleitao merged commit 9a884e6 into jorgecarleitao:main Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add format check in CI
3 participants