Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added more IPC documentation #534

Merged
merged 8 commits into from
Oct 17, 2021
Merged

Conversation

HagaiHargil
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #534 (f373afa) into main (ee68d18) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.01%     
==========================================
  Files         381      381              
  Lines       23744    23744              
==========================================
- Hits        19047    19045       -2     
- Misses       4697     4699       +2     
Impacted Files Coverage Δ
src/io/ipc/read/stream.rs 82.92% <ø> (ø)
src/io/ipc/write/stream.rs 73.33% <ø> (ø)
src/io/ipc/write/writer.rs 83.33% <ø> (ø)
src/compute/arithmetics/time.rs 44.89% <0.00%> (-2.05%) ⬇️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (-1.50%) ⬇️
src/io/avro/read/schema.rs 54.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee68d18...f373afa. Read the comment docs.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up! Left minor comments, imo ready to go.

src/io/ipc/mod.rs Outdated Show resolved Hide resolved
src/io/ipc/mod.rs Outdated Show resolved Hide resolved
src/io/ipc/read/stream.rs Outdated Show resolved Hide resolved
src/io/ipc/read/stream.rs Outdated Show resolved Hide resolved
src/io/ipc/read/stream.rs Outdated Show resolved Hide resolved
HagaiHargil and others added 4 commits October 17, 2021 08:31
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
@HagaiHargil
Copy link
Contributor Author

I believe that this should be it. There's obviously much more to write about the subject - i.e. I believe that the whole DictionaryBatch support is currently a bit lacking - but for now that's all I can offer :)

@jorgecarleitao jorgecarleitao added the documentation Improvements or additions to documentation label Oct 17, 2021
@jorgecarleitao jorgecarleitao merged commit 60ce40c into jorgecarleitao:main Oct 17, 2021
@jorgecarleitao
Copy link
Owner

Thanks a lot, @HagaiHargil 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants