Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed s3 example #536

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fixed s3 example #536

merged 1 commit into from
Oct 18, 2021

Conversation

jorgecarleitao
Copy link
Owner

There was a compilation error in the s3 example. It seems that Cargo test does not cover examples within packages, so we will also need to add CI tooling to check them.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #536 (34e4960) into main (13f8d09) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   81.28%   81.34%   +0.06%     
==========================================
  Files         380      380              
  Lines       23432    23938     +506     
==========================================
+ Hits        19046    19472     +426     
- Misses       4386     4466      +80     
Impacted Files Coverage Δ
src/io/parquet/write/record_batch.rs 84.61% <0.00%> (-6.69%) ⬇️
src/io/parquet/read/mod.rs 56.25% <0.00%> (-3.35%) ⬇️
tests/it/io/parquet/mod.rs 95.14% <0.00%> (-0.78%) ⬇️
src/io/parquet/read/boolean/nested.rs 87.32% <0.00%> (-0.68%) ⬇️
src/io/parquet/read/binary/nested.rs 87.05% <0.00%> (-0.25%) ⬇️
src/io/parquet/read/binary/basic.rs 83.87% <0.00%> (-0.24%) ⬇️
src/io/parquet/write/utils.rs 86.58% <0.00%> (-0.18%) ⬇️
src/io/parquet/read/boolean/basic.rs 91.52% <0.00%> (-0.15%) ⬇️
src/io/parquet/write/utf8/basic.rs 91.93% <0.00%> (-0.07%) ⬇️
src/io/parquet/mod.rs 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f8d09...34e4960. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit bd8f02b into main Oct 18, 2021
@jorgecarleitao jorgecarleitao deleted the fix_s3 branch October 18, 2021 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant