Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in reading fixed len binary from parquet #549

Merged
merged 1 commit into from Oct 24, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Oct 24, 2021

There was an error in using size that resulted in a panic.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Oct 24, 2021
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #549 (8749215) into main (e6b6c83) will increase coverage by 0.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   81.57%   81.66%   +0.09%     
==========================================
  Files         382      382              
  Lines       23386    23387       +1     
==========================================
+ Hits        19076    19100      +24     
+ Misses       4310     4287      -23     
Impacted Files Coverage Δ
src/io/parquet/read/fixed_size_binary.rs 75.32% <83.33%> (+24.67%) ⬆️
tests/it/io/parquet/read.rs 98.78% <100.00%> (+0.01%) ⬆️
src/io/ipc/write/common.rs 76.28% <0.00%> (+0.64%) ⬆️
src/bitmap/utils/slice_iterator.rs 94.02% <0.00%> (+1.49%) ⬆️
src/io/avro/read/schema.rs 55.95% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b6c83...8749215. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 788f382 into main Oct 24, 2021
@jorgecarleitao jorgecarleitao deleted the fix_decimal branch October 24, 2021 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant