Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified IPC stream writer / remove finish on drop from stream writer #575

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

jorgecarleitao
Copy link
Owner

Closes #574

Note that this is backward incompatible. To migrate:

  • the stream is no longer closed on drop: call finish explicitly to close the stream.
  • The writer is no longer encapsulated in a BufWriter: users need to explicitly do so (the writer may already be buffered)

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #575 (35f7a20) into main (ec11db5) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   78.89%   79.01%   +0.12%     
==========================================
  Files         395      395              
  Lines       24676    24771      +95     
==========================================
+ Hits        19467    19574     +107     
+ Misses       5209     5197      -12     
Impacted Files Coverage Δ
src/io/ipc/write/stream.rs 67.85% <0.00%> (-5.48%) ⬇️
src/compute/substring.rs 95.28% <0.00%> (-1.98%) ⬇️
src/array/utf8/mod.rs 86.84% <0.00%> (+5.26%) ⬆️
tests/it/compute/substring.rs 96.36% <0.00%> (+6.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec11db5...35f7a20. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 2fb2995 into main Nov 4, 2021
@jorgecarleitao jorgecarleitao deleted the ipc_stream branch November 4, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added StreamWriter::into_inner
1 participant