Added to conversion to FixedSizeBinary

[ritchie46]

This adds fn to conversion for FixedSizeBinary. This makes converting to another logical type consistent with primitive arrays.

I could add it to the other arrays as well.

[codecov]

Codecov Report

Merging #622 (ec52134) into main (61c2f3c) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   69.71%   69.74%   +0.03%     
==========================================
  Files         299      299              
  Lines       16599    16677      +78     
==========================================
+ Hits        11572    11632      +60     
- Misses       5027     5045      +18     

Impacted Files	Coverage Δ
src/array/fixed_size_binary/mod.rs	69.62% <0.00%> (-10.09%)	⬇️
src/bitmap/utils/slice_iterator.rs	91.04% <0.00%> (-1.50%)	⬇️
src/array/union/ffi.rs	0.00% <0.00%> (ø)
src/temporal_conversions.rs	74.82% <0.00%> (+0.34%)	⬆️
src/io/parquet/read/nested_utils.rs	78.43% <0.00%> (+0.98%)	⬆️
src/io/csv/write/serialize.rs	49.13% <0.00%> (+15.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c2f3c...ec52134. Read the comment docs.

[jorgecarleitao]

Thanks! I think we need to check that the data_type is a valid one and panic if not, like we do in from_data.

[ritchie46]

Thanks! I think we need to check that the data_type is a valid one and panic if not, like we do in from_data.

I didn't fully understand what we mean by valid in this case? If we use an extension type, do we know what is valid or not?

[jorgecarleitao]

The function get_size is the one that validates in the from_data, here:

        match data_type.to_logical_type() {
            DataType::FixedSizeBinary(size) => *size,
            _ => panic!("Wrong DataType"),
        }

in this case we need to verify that the size is still the same.

[jorgecarleitao]

(note that the .to_logical_type converts any extension type to its internal type, to take extension types into account ^_^)

[ritchie46]

Something like this? I assume we must check that the physical types are correct.

[jorgecarleitao]

exactly, this works!