Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified ArrowError #640

Merged
merged 1 commit into from Nov 27, 2021
Merged

Simplified ArrowError #640

merged 1 commit into from Nov 27, 2021

Conversation

jorgecarleitao
Copy link
Owner

  • Removed some errors that were not used or could be replaced by more expressive ones
  • Added new OutOfSpec error that covers many of the variants
  • Added #[non_exhaustive] to ArrowError to signal that new variants may emerge

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #640 (ff5b36a) into main (e8279a4) will decrease coverage by 0.11%.
The diff coverage is 11.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   69.92%   69.81%   -0.12%     
==========================================
  Files         299      299              
  Lines       16627    16679      +52     
==========================================
+ Hits        11626    11644      +18     
- Misses       5001     5035      +34     
Impacted Files Coverage Δ
src/array/fixed_size_list/mutable.rs 47.05% <0.00%> (ø)
src/compute/cast/dictionary_to.rs 24.39% <0.00%> (ø)
src/datatypes/field.rs 44.68% <0.00%> (ø)
src/datatypes/schema.rs 37.93% <ø> (ø)
src/error.rs 27.27% <0.00%> (+6.58%) ⬆️
src/io/avro/read/decompress.rs 80.64% <0.00%> (ø)
src/io/flight/mod.rs 0.00% <0.00%> (ø)
src/io/ipc/compression.rs 100.00% <ø> (ø)
src/io/ipc/read/array/dictionary.rs 42.10% <0.00%> (ø)
src/io/ipc/read/read_basic.rs 73.95% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8279a4...ff5b36a. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit f869146 into main Nov 27, 2021
@jorgecarleitao jorgecarleitao deleted the errors branch November 27, 2021 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant