Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made API to create field accept String #643

Merged
merged 2 commits into from Nov 28, 2021
Merged

Made API to create field accept String #643

merged 2 commits into from Nov 28, 2021

Conversation

jorgecarleitao
Copy link
Owner

When we already own the string, we should not need an extra allocation to create the field. This PR does this.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Nov 28, 2021
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #643 (747ef82) into main (35dfab3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   69.91%   69.91%           
=======================================
  Files         299      299           
  Lines       16628    16628           
=======================================
  Hits        11625    11625           
  Misses       5003     5003           
Impacted Files Coverage Δ
src/datatypes/schema.rs 37.93% <ø> (ø)
src/datatypes/field.rs 44.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dfab3...747ef82. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit f2c7503 into main Nov 28, 2021
@jorgecarleitao jorgecarleitao deleted the field branch November 28, 2021 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant