Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made IPC reader less restrictive #678

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Made IPC reader less restrictive #678

merged 2 commits into from
Dec 13, 2021

Conversation

jorgecarleitao
Copy link
Owner

  • Accept footers without dictionaries
  • Accept messages with other different versions

Closes #677

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #678 (f9e7dd8) into main (89921d3) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   69.60%   69.62%   +0.01%     
==========================================
  Files         301      301              
  Lines       16765    16766       +1     
==========================================
+ Hits        11670    11673       +3     
+ Misses       5095     5093       -2     
Impacted Files Coverage Δ
src/io/ipc/read/reader.rs 73.91% <57.14%> (+0.92%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89921d3...f9e7dd8. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 15ce4cf into main Dec 13, 2021
@jorgecarleitao jorgecarleitao deleted the fix_ipc branch December 13, 2021 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow2 cannnot open arrow IPC files written by Julia's Arrow.jl, Unable to get dictionaries from footer.
1 participant