Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made dyn Array and Scalar usable in #[derive(PartialEq)] #680

Merged
merged 1 commit into from Dec 13, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Dec 13, 2021

A small quality of life, as people can use these in structs and enums and still leverage the partial equality we offer in this crate.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #680 (9918726) into main (89921d3) will increase coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   69.60%   69.67%   +0.06%     
==========================================
  Files         301      301              
  Lines       16765    16844      +79     
==========================================
+ Hits        11670    11736      +66     
- Misses       5095     5108      +13     
Impacted Files Coverage Δ
src/array/equal/mod.rs 86.45% <33.33%> (-3.76%) ⬇️
src/scalar/equal.rs 60.00% <33.33%> (-5.22%) ⬇️
src/io/ipc/read/reader.rs 79.80% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89921d3...9918726. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 134a57f into main Dec 13, 2021
@jorgecarleitao jorgecarleitao deleted the better_eq branch December 13, 2021 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant