Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Do not write validity without nulls in IPC #688

Merged
merged 1 commit into from Dec 17, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Dec 17, 2021

Writing one is not prohibited, but smaller files are always better ^^

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #688 (bae2f75) into main (565cfae) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   69.77%   69.77%   -0.01%     
==========================================
  Files         303      303              
  Lines       16830    16829       -1     
==========================================
- Hits        11743    11742       -1     
  Misses       5087     5087              
Impacted Files Coverage Δ
src/io/ipc/write/serialize.rs 64.66% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565cfae...bae2f75. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit cc27dbe into main Dec 17, 2021
@jorgecarleitao jorgecarleitao deleted the ipc_write_validity branch December 17, 2021 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant