Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in compare booleans #721

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Fixed error in compare booleans #721

merged 1 commit into from
Dec 30, 2021

Conversation

jorgecarleitao
Copy link
Owner

Closed #719

Thanks @yjshen for the report!

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 30, 2021
@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #721 (4c36937) into main (d14ae86) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   70.59%   70.93%   +0.34%     
==========================================
  Files         312      312              
  Lines       16922    17253     +331     
==========================================
+ Hits        11946    12239     +293     
- Misses       4976     5014      +38     
Impacted Files Coverage Δ
src/compute/comparison/boolean.rs 87.75% <100.00%> (+0.52%) ⬆️
src/datatypes/field.rs 36.79% <0.00%> (-3.49%) ⬇️
src/io/json_integration/write/schema.rs 0.00% <0.00%> (ø)
src/io/avro/read/schema.rs 52.89% <0.00%> (+0.26%) ⬆️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/datatypes/mod.rs 82.94% <0.00%> (+1.12%) ⬆️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (+1.49%) ⬆️
src/io/ipc/write/schema.rs 95.22% <0.00%> (+2.39%) ⬆️
src/ffi/schema.rs 71.05% <0.00%> (+2.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14ae86...4c36937. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 0311e22 into main Dec 30, 2021
@jorgecarleitao jorgecarleitao deleted the fix_bool branch December 30, 2021 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when comparing BooleanArray with scalar using lt_eq_scalar
1 participant