Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made all panics in IPC read errors #722

Merged
merged 1 commit into from Jan 1, 2022
Merged

Made all panics in IPC read errors #722

merged 1 commit into from Jan 1, 2022

Conversation

jorgecarleitao
Copy link
Owner

Currently we panicked in malformed IPC. This PR changes all those instances to errors.

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #722 (2a1f1c5) into main (0311e22) will decrease coverage by 0.41%.
The diff coverage is 48.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   70.65%   70.23%   -0.42%     
==========================================
  Files         312      312              
  Lines       16894    16995     +101     
==========================================
  Hits        11936    11936              
- Misses       4958     5059     +101     
Impacted Files Coverage Δ
src/error.rs 30.76% <0.00%> (-5.60%) ⬇️
src/io/flight/mod.rs 0.00% <0.00%> (ø)
src/io/ipc/read/array/dictionary.rs 47.61% <ø> (ø)
src/io/ipc/read/array/list.rs 23.07% <10.00%> (-4.20%) ⬇️
src/io/ipc/read/array/map.rs 23.07% <10.00%> (-4.20%) ⬇️
src/io/ipc/read/array/union.rs 58.53% <15.38%> (-15.38%) ⬇️
src/io/ipc/read/array/fixed_size_list.rs 40.00% <37.50%> (-8.00%) ⬇️
src/io/ipc/read/read_basic.rs 70.29% <37.50%> (-3.67%) ⬇️
src/io/ipc/read/array/null.rs 50.00% <44.44%> (-10.00%) ⬇️
src/io/ipc/read/array/struct_.rs 77.14% <44.44%> (-12.86%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0311e22...2a1f1c5. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit b617331 into main Jan 1, 2022
@jorgecarleitao jorgecarleitao deleted the error branch January 1, 2022 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant