Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified Schema and Field #728

Merged
merged 1 commit into from Jan 5, 2022
Merged

Simplified Schema and Field #728

merged 1 commit into from Jan 5, 2022

Conversation

jorgecarleitao
Copy link
Owner

  • Schema no longer has its accessors, since all its attributes are public.
  • Field lost most of its accessors, since all its attributes are public.
  • merge_field, merge_datatypes, merge_schema was removed, since whether two fields or schemas can be merged is highly context dependent and can't be easily decided here

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #728 (ea5344d) into main (c28d69e) will increase coverage by 0.17%.
The diff coverage is 79.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   70.53%   70.71%   +0.17%     
==========================================
  Files         311      311              
  Lines       16920    16853      -67     
==========================================
- Hits        11934    11917      -17     
+ Misses       4986     4936      -50     
Impacted Files Coverage Δ
benches/filter_kernels.rs 0.00% <ø> (ø)
src/array/struct_/mod.rs 56.92% <0.00%> (ø)
src/compute/sort/mod.rs 26.66% <0.00%> (ø)
src/datatypes/mod.rs 97.22% <ø> (ø)
src/io/ipc/write/stream_async.rs 55.55% <0.00%> (ø)
src/io/json_integration/read/array.rs 79.50% <ø> (ø)
src/io/json_integration/write/schema.rs 0.00% <0.00%> (ø)
src/io/parquet/read/schema/metadata.rs 74.19% <ø> (ø)
src/io/parquet/write/mod.rs 62.31% <ø> (ø)
src/compute/cast/mod.rs 93.91% <50.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28d69e...ea5344d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant