Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to read and write float dict from parquet #778

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

jorgecarleitao
Copy link
Owner

Somehow this type slipped through the cracks of the datatype match.

Close #777

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #778 (8e5bc71) into main (84a4911) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   70.99%   70.98%   -0.01%     
==========================================
  Files         316      316              
  Lines       16733    16739       +6     
==========================================
+ Hits        11879    11883       +4     
- Misses       4854     4856       +2     
Impacted Files Coverage Δ
src/io/parquet/read/mod.rs 39.07% <25.00%> (-0.25%) ⬇️
src/io/parquet/write/dictionary.rs 55.67% <50.00%> (-0.12%) ⬇️
src/io/ipc/write/schema.rs 97.82% <0.00%> (+0.72%) ⬆️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a4911...8e5bc71. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 98f6e45 into main Jan 19, 2022
@jorgecarleitao jorgecarleitao deleted the dict_float branch January 19, 2022 15:12
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float32 Dictionary Encoding
1 participant