Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Reduced code duplication #805

Merged
merged 2 commits into from Feb 4, 2022
Merged

Reduced code duplication #805

merged 2 commits into from Feb 4, 2022

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #805 (6c29f69) into main (8fcab5c) will increase coverage by 0.08%.
The diff coverage is 54.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   71.27%   71.36%   +0.08%     
==========================================
  Files         326      327       +1     
  Lines       17506    17435      -71     
==========================================
- Hits        12478    12442      -36     
+ Misses       5028     4993      -35     
Impacted Files Coverage Δ
src/io/parquet/read/binary/basic.rs 79.38% <ø> (ø)
src/io/parquet/read/binary/mod.rs 100.00% <ø> (ø)
src/io/parquet/read/boolean/basic.rs 76.78% <ø> (ø)
src/io/parquet/read/boolean/mod.rs 100.00% <ø> (ø)
src/io/parquet/read/fixed_size_binary/basic.rs 79.77% <ø> (ø)
src/io/parquet/read/mod.rs 81.10% <ø> (+21.77%) ⬆️
src/io/parquet/read/primitive/mod.rs 100.00% <ø> (ø)
src/io/parquet/read/deserialize/mod.rs 47.08% <47.08%> (ø)
src/io/parquet/read/dictionary.rs 55.12% <51.35%> (-8.29%) ⬇️
src/io/parquet/read/primitive/dictionary.rs 80.95% <80.00%> (+20.95%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcab5c...6c29f69. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 694b895 into main Feb 4, 2022
@jorgecarleitao jorgecarleitao deleted the simpler branch February 4, 2022 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant