Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Refactored (internal) fmt #842

Merged
merged 2 commits into from Feb 15, 2022
Merged

Refactored (internal) fmt #842

merged 2 commits into from Feb 15, 2022

Conversation

jorgecarleitao
Copy link
Owner

This PR makes writing to Debug and to io::print faster by lifting common logic to an API that allows stream writing to an implementor of std::fmt::Write.

It also makes this part of the code a bit more linear.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #842 (f165759) into main (2c4dbb2) will increase coverage by 0.35%.
The diff coverage is 67.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   71.55%   71.90%   +0.35%     
==========================================
  Files         326      336      +10     
  Lines       17643    18184     +541     
==========================================
+ Hits        12624    13076     +452     
- Misses       5019     5108      +89     
Impacted Files Coverage Δ
src/array/binary/mod.rs 87.35% <ø> (+6.50%) ⬆️
src/array/boolean/mod.rs 70.42% <ø> (-0.82%) ⬇️
src/array/dictionary/mod.rs 77.96% <ø> (+7.19%) ⬆️
src/array/fixed_size_binary/mod.rs 68.42% <ø> (-1.20%) ⬇️
src/array/fixed_size_list/fmt.rs 0.00% <0.00%> (ø)
src/array/fixed_size_list/mod.rs 71.66% <ø> (+2.31%) ⬆️
src/array/list/mod.rs 81.48% <ø> (+0.08%) ⬆️
src/array/mod.rs 62.76% <ø> (-8.29%) ⬇️
src/array/primitive/mod.rs 80.23% <ø> (ø)
src/array/struct_/mod.rs 64.06% <ø> (+4.64%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4dbb2...f165759. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 3b56b97 into main Feb 15, 2022
@jorgecarleitao jorgecarleitao deleted the debug branch February 15, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant