This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Bug fix in offset for sliced unions #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncpenke
commented
Mar 7, 2022
| offsets: self | ||
| .offsets | ||
| .clone() | ||
| .map(|offsets| offsets.slice(offset, length)), |
There was a problem hiding this comment.
@jorgecarleitao For dense unions wasn't sure if slicing the offsets or using (index + offset) in field_slot was more correct.
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
=======================================
Coverage 70.30% 70.30%
=======================================
Files 343 343
Lines 18768 18768
=======================================
Hits 13194 13194
Misses 5574 5574
Continue to review full report at Codecov.
|
|
Thanks a lot @ncpenke , this is indeed a bug. |
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.