Added pop to utf8/binary/fixedSize MutableArray

[ygf11]

No description provided.

[codecov]

Codecov Report

Merging #966 (296d7e7) into main (8fb3b8d) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   71.09%   71.49%   +0.39%     
==========================================
  Files         351      355       +4     
  Lines       19456    19602     +146     
==========================================
+ Hits        13832    14014     +182     
+ Misses       5624     5588      -36     

Impacted Files	Coverage Δ
src/array/binary/mutable.rs	83.53% <100.00%> (+4.96%)	⬆️
src/array/fixed_size_binary/mutable.rs	86.13% <100.00%> (+2.44%)	⬆️
src/array/utf8/mutable.rs	87.02% <100.00%> (+5.41%)	⬆️
src/io/parquet/write/primitive/nested.rs	83.33% <0.00%> (-3.04%)	⬇️
src/io/parquet/write/mod.rs	58.51% <0.00%> (-1.96%)	⬇️
src/bitmap/utils/slice_iterator.rs	86.20% <0.00%> (-1.73%)	⬇️
src/io/parquet/read/statistics/primitive.rs	58.33% <0.00%> (-1.67%)	⬇️
src/io/parquet/read/statistics/utf8.rs	81.81% <0.00%> (ø)
src/io/parquet/read/statistics/list.rs	55.17% <0.00%> (ø)
src/io/parquet/read/statistics/dictionary.rs	46.15% <0.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb3b8d...296d7e7. Read the comment docs.

[jorgecarleitao]

Thanks @ygf11 , looks awesome!

I left minor suggestions but it is otherwise ready to merge.

[ygf11]

BTW, I am confused why there is no need to operate validity in push_null() of FixedSizeBinaryArray?

arrow2/src/array/fixed_size_binary/mutable.rs

Lines 222 to 224 in 9ecb8ef

	fn push_null(&mut self) {
	self.values.resize(self.values.len() + self.size, 0);
	}

[jorgecarleitao]

BTW, I am confused why there is no need to operate validity in push_null() of FixedSizeBinaryArray?

arrow2/src/array/fixed_size_binary/mutable.rs

Lines 222 to 224 in 9ecb8ef

	fn push_null(&mut self) {
	self.values.resize(self.values.len() + self.size, 0);
	}

it is a bug!

[ygf11]

it is a bug!

I will try to fix it in another pr.