Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed API bug in async read of IPC metadata #969

Merged
merged 1 commit into from Apr 29, 2022
Merged

Fixed API bug in async read of IPC metadata #969

merged 1 commit into from Apr 29, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Apr 29, 2022

It was receiving the reader by value instead of by mutable reference.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #969 (ba04c64) into main (9ecb8ef) will increase coverage by 0.33%.
The diff coverage is 87.32%.

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   71.44%   71.77%   +0.33%     
==========================================
  Files         355      355              
  Lines       19572    19826     +254     
==========================================
+ Hits        13984    14231     +247     
- Misses       5588     5595       +7     
Impacted Files Coverage Δ
src/io/ipc/read/file_async.rs 60.86% <80.95%> (+0.23%) ⬆️
src/io/ipc/read/reader.rs 77.08% <90.00%> (+1.52%) ⬆️
src/bitmap/utils/slice_iterator.rs 86.20% <0.00%> (-1.73%) ⬇️
src/io/parquet/write/levels.rs 96.37% <0.00%> (+1.69%) ⬆️
src/array/fixed_size_binary/mutable.rs 86.82% <0.00%> (+2.03%) ⬆️
src/array/mod.rs 67.02% <0.00%> (+2.12%) ⬆️
src/array/utf8/mutable.rs 88.67% <0.00%> (+2.47%) ⬆️
src/array/binary/mutable.rs 87.02% <0.00%> (+4.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecb8ef...ba04c64. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 3a3e41b into main Apr 29, 2022
@jorgecarleitao jorgecarleitao deleted the fix_api branch April 29, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant