Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Renamed ArrowError to Error #993

Merged
merged 2 commits into from May 27, 2022
Merged

Renamed ArrowError to Error #993

merged 2 commits into from May 27, 2022

Conversation

jorgecarleitao
Copy link
Owner

The rest of the ecosystem uses Error to describe the crate own errors, see e.g. std::io::Error, tokio::time::error::Error, serde::de::Error, odbc_api::Error, lexical_core::Error.

I would like to propose that we align our error name with the rest of the ecosystem, to reduce the mental load of using this crate and make the crate a bit more standard also in this aspect.

Any thoughts?

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #993 (7c3460f) into main (b5bbe9f) will increase coverage by 0.09%.
The diff coverage is 19.48%.

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   71.59%   71.68%   +0.09%     
==========================================
  Files         359      359              
  Lines       19879    19860      -19     
==========================================
+ Hits        14232    14237       +5     
+ Misses       5647     5623      -24     
Impacted Files Coverage Δ
src/array/boolean/mod.rs 73.41% <0.00%> (ø)
src/array/fixed_size_binary/mutable.rs 86.13% <0.00%> (ø)
src/array/fixed_size_list/mutable.rs 47.29% <0.00%> (ø)
src/array/ord.rs 71.60% <0.00%> (ø)
src/chunk.rs 84.61% <0.00%> (ø)
src/compute/aggregate/min_max.rs 75.36% <0.00%> (ø)
src/compute/aggregate/sum.rs 78.26% <0.00%> (ø)
src/compute/arithmetics/decimal/add.rs 96.55% <0.00%> (ø)
src/compute/arithmetics/decimal/div.rs 77.50% <0.00%> (ø)
src/compute/arithmetics/decimal/mod.rs 100.00% <ø> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bbe9f...7c3460f. Read the comment docs.

@ritchie46
Copy link
Collaborator

ritchie46 commented May 18, 2022

Sounds good to me. Easily upgraded with use arrow::error::Error as ArrowError.

@jorgecarleitao jorgecarleitao changed the title [proposal] Rename ArrowError to Error Rename ArrowError to Error May 26, 2022
@jorgecarleitao jorgecarleitao force-pushed the error_rename branch 2 times, most recently from 8523329 to a6b0d33 Compare May 26, 2022 20:12
@jorgecarleitao jorgecarleitao merged commit bbe7209 into main May 27, 2022
@jorgecarleitao jorgecarleitao deleted the error_rename branch May 27, 2022 13:18
@jorgecarleitao jorgecarleitao changed the title Rename ArrowError to Error Renamed ArrowError to Error May 27, 2022
@jorgecarleitao jorgecarleitao removed the help wanted Extra attention is needed label May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants