Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified tests #104

Merged
merged 1 commit into from Mar 19, 2022
Merged

Simplified tests #104

merged 1 commit into from Mar 19, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Mar 19, 2022

This moves the integration tests to tests/it, following the practice outlined here

@jorgecarleitao jorgecarleitao added the testing PRs to improve testing, CI, coverage, etc. label Mar 19, 2022
@jorgecarleitao jorgecarleitao force-pushed the better_tests branch 2 times, most recently from fe0bb83 to 4852946 Compare March 19, 2022 10:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #104 (6386cc1) into main (a6e6cf3) will decrease coverage by 6.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   68.09%   61.75%   -6.34%     
==========================================
  Files          72       66       -6     
  Lines        3911     2782    -1129     
==========================================
- Hits         2663     1718     -945     
+ Misses       1248     1064     -184     
Impacted Files Coverage Δ
src/encoding/delta_length_byte_array/encoder.rs 77.77% <0.00%> (-22.23%) ⬇️
src/write/mod.rs 75.00% <0.00%> (-17.41%) ⬇️
src/schema/io_message/from_message.rs 66.87% <0.00%> (-14.56%) ⬇️
src/read/mod.rs 83.87% <0.00%> (-9.60%) ⬇️
src/compression.rs 82.22% <0.00%> (-6.02%) ⬇️
src/write/page.rs 47.22% <0.00%> (-2.78%) ⬇️
src/encoding/uleb128.rs 95.45% <0.00%> (-2.66%) ⬇️
src/encoding/bitpacking.rs 95.91% <0.00%> (-2.16%) ⬇️
src/encoding/delta_bitpacked/decoder.rs 93.18% <0.00%> (-1.61%) ⬇️
src/schema/io_thrift/to_thrift.rs 97.14% <0.00%> (-0.42%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e6cf3...6386cc1. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 6511088 into main Mar 19, 2022
dantengsky pushed a commit to datafuse-extras/parquet2 that referenced this pull request Apr 1, 2022
@jorgecarleitao jorgecarleitao deleted the better_tests branch April 22, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs to improve testing, CI, coverage, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants