Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional async #174

Merged
merged 1 commit into from Aug 10, 2022
Merged

Optional async #174

merged 1 commit into from Aug 10, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Aug 10, 2022

This PR makes async optional, to reduce the dependency tree.

Users must how pass the feature async to activate all async functionality.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #174 (82fd4c4) into main (e556d78) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          78       78           
  Lines        7898     7898           
=======================================
  Hits         6752     6752           
  Misses       1146     1146           
Impacted Files Coverage Δ
src/read/mod.rs 91.72% <ø> (ø)
src/write/column_chunk.rs 89.69% <ø> (ø)
src/write/indexes/write.rs 100.00% <ø> (ø)
src/write/mod.rs 75.00% <ø> (ø)
src/write/page.rs 80.00% <ø> (ø)
src/write/row_group.rs 93.37% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants