LPS-47260 Simplify handling of multi valued keys and make registration of settings structure easier #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keys from the Settings classes instead of doing it in the ConfigurationActionImpl class.
…urationActionImpl classes as they will be moved to their Settings counterparts in the next commits.
…e and reuse the registration logic for fallback keys and multi valued keys of high level settings.
…lti valued configuration keys (some were missing).
izaera
changed the title
|
Just started reviewing :) |
Sent from
|
Pull request submitted to brianchandotcom#19196. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.