Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from AVPlayer failed #60

Merged
merged 7 commits into from
May 11, 2019
Merged

Conversation

jorgenhenrichsen
Copy link
Owner

Will create a new AVPlayer instance when the current one is failed.
Fixes #56 .

They will also stop observing the current AVPlayer if a new one is going to be set.
The AudioSession category will need to be set again when this event is emitted.
@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #60 into master will decrease coverage by 0.84%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   79.93%   79.08%   -0.85%     
==========================================
  Files          17       17              
  Lines         917      942      +25     
==========================================
+ Hits          733      745      +12     
- Misses        184      197      +13
Impacted Files Coverage Δ
SwiftAudio/Classes/Event.swift 96.42% <ø> (ø) ⬆️
SwiftAudio/Classes/AudioPlayer.swift 82.44% <33.33%> (-1.28%) ⬇️
...udio/Classes/AVPlayerWrapper/AVPlayerWrapper.swift 81.08% <50%> (-4.22%) ⬇️
...tAudio/Classes/Observer/AVPlayerTimeObserver.swift 93.93% <88.23%> (-6.07%) ⬇️
SwiftAudio/Classes/Observer/AVPlayerObserver.swift 89.36% <93.75%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8c83f...92a804e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player becomes unresponsive after failure to play track.
2 participants