Add ability to set asset init options #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgenhenrichsen
requested changes
Jul 8, 2019
SwiftAudio/Classes/AudioItem.swift
Outdated
| @@ -36,6 +36,11 @@ public protocol InitialTiming { | |||
| func getInitialTime() -> TimeInterval | |||
| } | |||
|
|
|||
| /// Make your `AudioItem`-subclass conform to this protocol to control enable the ability to set initialization options for the asset. | |||
There was a problem hiding this comment.
Make your AudioItem-subclass conform to this protocol to control enable the ability to set initialization options for the asset.
There was a problem hiding this comment.
Maybe also link to these docs to make it clear what options are to be provided.
SwiftAudio/Classes/AudioItem.swift
Outdated
| @@ -125,3 +130,24 @@ public class DefaultAudioItemInitialTime: DefaultAudioItem, InitialTiming { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| /// An AudioItem that also conforms to the `AssetOptionsProviding`-protocol | |||
| public class DefaultAudioItemAuthorizing: DefaultAudioItem, AssetOptionsProviding { | |||
There was a problem hiding this comment.
Change the naming of the class to DefaultAudioItemAssetOptionsProviding.
SwiftAudio/Classes/AudioItem.swift
Outdated
| @@ -36,6 +36,11 @@ public protocol InitialTiming { | |||
| func getInitialTime() -> TimeInterval | |||
| } | |||
|
|
|||
| /// Make your `AudioItem`-subclass conform to this protocol to control enable the ability to set initialization options for the asset. | |||
| public protocol AssetOptionsProviding { | |||
| func getAssetOptions() -> [String : Any] | |||
There was a problem hiding this comment.
[String: Any] for consistency.
SwiftAudio/Classes/AudioItem.swift
Outdated
| super.init(audioUrl: audioUrl, artist: artist, title: title, albumTitle: albumTitle, sourceType: sourceType, artwork: artwork) | ||
| } | ||
|
|
||
| public func getAssetOptions() -> [String : Any] { |
There was a problem hiding this comment.
[String: Any] for consistency.
| @@ -19,7 +19,6 @@ public enum PlaybackEndedReason: String { | |||
| } | |||
|
|
|||
| class AVPlayerWrapper: AVPlayerWrapperProtocol { | |||
|
|
|||
There was a problem hiding this comment.
Probably not meant to remove this newline.
|
Fixed the issues @jorgenhenrichsen :) obviously I made this PR a bit too fast. Should all be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68