Fix wrong line number in interpreter errors #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `elpy-shell--region-without-indentation` with the function `python-shell-buffer-substring` from python.el.
1 similar comment
|
LGTM |
galaunay
added a commit
to galaunay/elpy
that referenced
this pull request
Jan 30, 2019
…r#1520) Replace `elpy-shell--region-without-indentation` with the function `python-shell-buffer-substring` from python.el.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow #1505.
Sending region of code with Elpy confuses the interpreter, that displays wrong line numbers when error are raised or when using pdb.
Replacing the function extracting region of codes in Elpy (
elpy-shell--region-without-indentation) with a function from python.el (python-shell-buffer-substring) fixes this issue.PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):