Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix1414 #1712

Merged
merged 4 commits into from
Nov 10, 2019
Merged

Fix1414 #1712

merged 4 commits into from
Nov 10, 2019

Conversation

galaunay
Copy link
Collaborator

@galaunay galaunay commented Nov 6, 2019

PR Summary

Follow #1414 .

Make sure the setup code sent by Elpy after shell creation is sent after the first prompt is received.

This prevent the shell from hanging in some situations (with Jupyter at least).

PR checklist

  • Commits respect our guidelines
  • Tests are passing properly (see here on how to run Elpy's tests)
  • Tests has been added to cover the change

This prevent the shell from hanging in some situations
@galaunay galaunay force-pushed the Fix1414 branch 4 times, most recently from ba68907 to 91a6ccc Compare November 10, 2019 00:06
@coveralls
Copy link

coveralls commented Nov 10, 2019

Coverage Status

Coverage decreased (-0.03%) to 92.007% when pulling 75c5940 on galaunay:Fix1414 into ee0f5c9 on jorgenschaefer:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants