Make after-change-function save match data. #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpy-folding--mark-foldable-lines disrupts editing activities, like query replace, because it fails to save match data. Here's relevant instructions from the Elisp Manual (in Emacs 26.3): 32.30 Change Hooks ... "The functions you use in these hooks should save and restore the match data if they do anything that uses regular expressions; otherwise, they will interfere in bizarre ways with the editing operations that call them."
|
Legitimate, thanks for the PR. I am happy to see that someone is using the folding module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
elpy-folding--mark-foldable-lines was disrupting editing activities, like query replace, because it failed to save match data. This PR fixes that, wrapping the effective body of the function in save-match-data. I also wrapped resulting long lines.
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
For new features only: