Fix #1823: support newer eldoc protocol #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This UNTESTED commit should hint at how to fix the issue without resorting to `eldoc-docstring-format-sym-doc', which is gone in Emacs 28 (ElDoc 1.1.0). Beyond the ideas delineated in this commit, the new ElDoc protocol would also easily obviate the need to have "flymake-specific" ElDoc code in ElPy (this is now default in stock Flymake), as well as being forced to choose between different types of ElPy docstrings. * elpy.el (elpy-module-eldoc): Add to eldoc-documentation-functions. (elpy-eldoc-documentation): Rework to support eldoc-documentation-functions.
|
Thanks for that. I took the liberty to make minor changes and fix the failing test. |
Cool. Did you actually test it on Emacs 28? Becasue I didn't. I'm sorry if I didn't make it clearer earlier (EDIT: actually, I did make it all caps clear... :-) ) |
|
You did make it clear :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This UNTESTED commit should hint at how to fix the issue without
resorting to `eldoc-docstring-format-sym-doc', which is gone in Emacs
28 (ElDoc 1.1.0).
Beyond the ideas delineated in this commit, the new ElDoc protocol
would also easily obviate the need to have "flymake-specific" ElDoc
code in ElPy (this is now default in stock Flymake), as well as being
forced to choose between different types of ElPy docstrings.
(elpy-eldoc-documentation): Rework to support
eldoc-documentation-functions.
PR Summary
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
For new features only: