Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring the action to perform on encountering a warn-condition #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Configuring the action to perform on encountering a warn-condition #3

wants to merge 5 commits into from

Commits on Mar 18, 2012

  1. Config file framework and per-check disabling 

    It should be pretty trivial to enhance this to become "choose whether
you want an error or warning".
    Robert J. Macomber committed Mar 18, 2012
    Copy the full SHA
    ed8b8cc View commit details
    Browse the repository at this point in the history

  2. Make errors warnings on a per-check basis

    Robert J. Macomber committed Mar 18, 2012
    Copy the full SHA
    d531759 View commit details
    Browse the repository at this point in the history

  3. Allow setting default action

    Robert J. Macomber committed Mar 18, 2012
    Copy the full SHA
    89c2db9 View commit details
    Browse the repository at this point in the history

  4. Document the properties file.

    Robert J. Macomber committed Mar 18, 2012
    Copy the full SHA
    dd94cde View commit details
    Browse the repository at this point in the history

  5. Refactor warning-case detection out 

    Presumably this plugin will end up with many more warnings.  This will
prevent LinterPlugin.scala from getting unweildly huge.  Also it removes
some boilerplate of the form

  case ... if warningEnable(Warnings.ThisWarning) && ... =>
    onWarn(Warnings.ThisWarning)...

That double "Warnings.ThisWarning" was setting my teeth on edge.

Unfortunately, it introduces a pair of typecasts!  I cannot convince scalac
that my references to a Global are all references to the *same* Global.
    Robert J. Macomber committed Mar 18, 2012
    Copy the full SHA
    d99f335 View commit details
    Browse the repository at this point in the history