Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alphabets: spanish, english and ascii #5

Merged
merged 1 commit into from Apr 17, 2019
Merged

Conversation

jorgepiloto
Copy link
Owner

This PR partially solves for #2, since integrates some of the alphabets asked for in that issue. Further investigation on ASCII printable characters is needed and also in UTF-8 before including more alphabets 馃悕

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #5 into master will increase coverage by 21.56%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
+ Coverage   66.66%   88.23%   +21.56%     
===========================================
  Files           4        6        +2     
  Lines          12       34       +22     
  Branches        1        1               
===========================================
+ Hits            8       30       +22     
  Misses          4        4
Impacted Files Coverage 螖
src/cipherkit/alphabets.py 100% <100%> (酶)
tests/test_alphabets.py 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8716ade...aaf85f1. Read the comment docs.

@jorgepiloto jorgepiloto merged commit 040cb7c into master Apr 17, 2019
@jorgepiloto jorgepiloto deleted the alphabets branch April 17, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants