fix(postgres): fixing postgres connection #17
Conversation
|
The main idea of this is to be able to connect to a specific database, but this PR does not handle that scenario, it only fixes the connection url being saved with the database name but when you connect to that url, the tree stills shows every database that lives in the server. I think this only makes sense to merge if we could handle that scenario. |
yes, the tree show all the databases but it doesn't allow you to see the data or select others databases, only the one is passed in the string connection |
|
Yeah, but i think it would be confusing to be allowed to see other databases but not be able to interact with them. If i put a database in the connection string i would expect to only connect and see that specific database. |
You are right, let me fix that and open the PR again |
fix(postgres): fixing postgres connection fix(db-name): improve the store of dbName fix(db-name): fix dbName if not passed fix(db-name): improve the handle of dbname path
|
@jorgerojas26 Done!. Now only show the database that is passed in the dbName |
|
@KevenGoncalves awesome bro. I like that. Can you please resolve the conflicts?. I will merge this. |
|
Let me try to fix it |
|
@jorgerojas26 Merge conflict fixed |
This fix the problem of lazysql not opening a postgres connection because the missing dbName path
#16