Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows Icon #26

Closed
wants to merge 2 commits into from
Closed

Update Windows Icon #26

wants to merge 2 commits into from

Conversation

LordNyriox
Copy link

@LordNyriox LordNyriox commented Jun 16, 2022

I converted the modern Mac/Linux icons to fit the Windows icon format, replacing the icon from the ancient "Ideas From the Deep" port. In compliance with Bugdom.exe.rc#L11, all embedded size layers are without PNG compression.

Icon layers scaled using @bricelam's ImageResizer 3.1.2, then combined into an ICO file using GIMP 2.10.32.

Size Layers: { 256x256 (32-bit color), 48x48 (32-bit color), 32x32 (original indexed icon) }

Convert current Mac/Linux icons to Windows XP icon format. All sizes 32-bit uncompressed.
Sizes: { 256,128, 96, 64, 48, 32, 16 }
@jorio
Copy link
Owner

jorio commented Jun 19, 2022

Thank you for your PR and for taking the time to research how to correctly generate the icon!

I'd like to keep the old 32x32 icon because I like the idea of preserving the OS 9 icon on at least one of the target platforms. However, adding a hi-res icon in addition to the old-school icon is a good idea.

To keep the file under 300 KB, I suggest keeping just 32x32 (indexed-color original), 48x48 (your rescaled version) and 256x256. Windows 10 will downscale the 256x256 icon as needed for sizes larger than 48.

Convert current Mac/Linux icons to Windows XP icon format.  All sizes uncompressed.
Sizes: { 256x256 (32-bit), 48x48 (32-bit), 32x32 (indexed original) }
@LordNyriox
Copy link
Author

LordNyriox commented Jun 19, 2022

I suggest keeping just 32x32 (indexed-color original), 48x48 (your rescaled version) and 256x256.

Icon built and uploaded. Fair warning, I only use the browser interface of Github, so I cannot squash the commits in the PR branch.

@jorio
Copy link
Owner

jorio commented Jun 20, 2022

Np, I'll squash it myself when I'm ready to merge. Thanks!

@LordNyriox
Copy link
Author

@jorio: Off-topic, I am working on a "modernized" fork of Bugdom, and could use some technical advice on the code.

Would it be be alright for me to post Bugdom code questions in [#24], since implementing that issue is where I started my fork?

@jorio
Copy link
Owner

jorio commented Jun 20, 2022

Sure! I'll be happy to help. You can also contact me directly if you wish (email address in my profile).

@jorio
Copy link
Owner

jorio commented Jul 22, 2022

@LordNyriox, I think this PR got automatically closed when you recreated your repo before I got a chance to merge it. I can re-add the icon manually, or you can submit a new PR if you like.

@LordNyriox
Copy link
Author

@jorio:

I can re-add the icon manually

I honestly forgot about this PR until after I had already reset my forked repository.

Feel free to manually rebase or merge the icon commit as you wish. 😄

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants