Fixup table #2
Merged
Fixup table #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | User specification | Concrete dtype | String alias | Note | | ||
| |------------------------------------------|---------------------------------------------------------------|---------------------------------------|----------| | ||
| | Unspecified (inference) | `StringDtype(storage="pyarrow"\|"python", na_value=np.nan)` | "string" | (1) | | ||
| | `StringDtype()` or `"string"` | `StringDtype(storage="pyarrow" \| "python", na_value=np.nan)` | "string" | (1), (2) | |
There was a problem hiding this comment.
The problem is that for our online web version, the \ just renders as well and doesn't seem to work as escaping the |.
Now, short term people are mostly looking at this through the github diff, so maybe this is worth it, and I should just remember to switch it back before merging ..
There was a problem hiding this comment.
Ah, I see. No problem if you just want to close this then. Reading with the \ in there is still very manageable on the webpage; whereas it is not readable on GitHub. But this is quite minor regardless.
There was a problem hiding this comment.
Yes, that is a good reason for now to merge this!
jorisvandenbossche
merged commit 2c58c4c
into
jorisvandenbossche:pdep-string-dtype
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This should allow the table to render in GitHub.