replaced scoped blocks #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obitech
reviewed
Aug 28, 2019
There was a problem hiding this comment.
I don't really understand the point of using anonymous functions for defer here. All of them are at the end of their respective encapsulating functions, so why bother with a new stack frame? defer would be called in any case if the upper function returns right? I haven't quite grasped the need for the additonal nesting to be honest.
Alternatively, maybe you can layout the expected behaviour vs. what's actually happening in:
- no scoping
- scoped blocks (used previously)
- anonymous functions
| continue | ||
| } | ||
| // anonymous function for safely calling defer | ||
| func() { |
There was a problem hiding this comment.
I don't really understand why this has to be an anonymous function. The function is returning after this whole block anyway, so there shouldn't be any issues with calling ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scoped blocks were replaced by anonymous functions, since defer calls are only triggered when leaving a function frame and not a scope.