Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbox is not safely parsing when contents include code #609

Closed
napter opened this issue Jan 11, 2024 · 1 comment
Closed

Chatbox is not safely parsing when contents include code #609

napter opened this issue Jan 11, 2024 · 1 comment

Comments

@napter
Copy link

napter commented Jan 11, 2024

Describe the bug
The following input gets no response and causes a console error that references the onopen function from the code. It appears that the code is somehow being executed - or at the very least not safely parsed.

To Reproduce
Try sending the following:


change the modal to use nextui modal. dont output all the code, just the parts that we need to change:
The Modal handles the focus within the modal content. It means that you can use the modal with form elements without any problem. the focus returns to the trigger when the modal closes.


Preview

Code
App.jsx
MailIcon.jsx
LockIcon.jsx
import React from "react";
import {Modal, ModalContent, ModalHeader, ModalBody, ModalFooter, Button, useDisclosure, Checkbox, Input, Link} from "@nextui-org/react";
import {MailIcon} from './MailIcon.jsx';
import {LockIcon} from './LockIcon.jsx';

export default function App() {
  const {isOpen, onOpen, onOpenChange} = useDisclosure();

  return (
    <>
      <Button onPress={onOpen} color="primary">Open Modal</Button>
      <Modal 
        isOpen={isOpen} 
        onOpenChange={onOpenChange}
        placement="top-center"
      >
        <ModalContent>
          {(onClose) => (
            <>
              <ModalHeader className="flex flex-col gap-1">Log in</ModalHeader>
              <ModalBody>
                <Input
                  autoFocus
                  endContent={
                    <MailIcon className="text-2xl text-default-400 pointer-events-none flex-shrink-0" />
                  }
                  label="Email"
                  placeholder="Enter your email"
                  variant="bordered"
                />
                <Input
                  endContent={
                    <LockIcon className="text-2xl text-default-400 pointer-events-none flex-shrink-0" />
                  }
                  label="Password"
                  placeholder="Enter your password"
                  type="password"
                  variant="bordered"
                />
                <div className="flex py-2 px-1 justify-between">
                  <Checkbox
                    classNames={{
                      label: "text-small",
                    }}
                  >
                    Remember me
                  </Checkbox>
                  <Link color="primary" href="#" size="sm">
                    Forgot password?
                  </Link>
                </div>
              </ModalBody>
              <ModalFooter>
                <Button color="danger" variant="flat" onPress={onClose}>
                  Close
                </Button>
                <Button color="primary" onPress={onClose}>
                  Sign in
                </Button>
              </ModalFooter>
            </>
          )}
        </ModalContent>
      </Modal>
    </>
  );
}

It throws in console:
Uncaught (in promise) TypeError: Cannot create property 'u' on string '{onOpen}'
at I (shared.js:2:746597)
...

Please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Extension Version: 2.4.8

Additional context
其他
Add any other context about the problem here.

josStorer added a commit that referenced this issue Jan 26, 2024
@josStorer
Copy link
Owner

fixed in v2.4.9
and it's also recommended to wrap your code in
```
YOUR CODE
```

mrichtarsky added a commit to mrichtarsky/chatGPTBox that referenced this issue Feb 13, 2024
* origin/master:
  Update OpenAI ChatGPT Turbo models (API) (josStorer#620)
  release v2.4.9
  when opening IndependentPanel, if the latest session has been used, automatically create a new session (josStorer#601)
  presearch support (josStorer#592)
  formattedError (josStorer#572)
  safe markdown renderer (josStorer#609, josStorer#403)
  improve the stability of response language (josStorer#611)
  improve bilibili summary
  fix mounting failure caused by DuckDuckGo's initial rendering delay. josStorer#610
  gpt-4 web DALL·E support
  chore
  improve josStorer#603
  improve markdown styles (josStorer#585)
  fix gpt-4 web unusual activity (josStorer#615)
  fix: bilibili reload (josStorer#603)
  refactor(selection-tools): remove redundant `getPreferredLanguage` calls (josStorer#593)
  Fix GPT-4 model name and confusion in names (josStorer#584)
  chore(deps): bump actions/upload-artifact from 3 to 4 (josStorer#594)
  chore(deps): bump actions/setup-python from 4 to 5 (josStorer#586)
  update readme news
  release v2.4.8
  update core content adapters
  fix eventsource meta (josStorer#579, josStorer#567)
  josStorer#573's patch
  release v2.4.7
  fix josStorer#569 and reduce menu items
  add gpt-3.5-turbo-instruct
  fix global side_panel
  patch to josStorer#564
  Update Claude.ai web to Claude v2.1, fix josStorer#570 (josStorer#573)
  Add ChatGLM API (josStorer#567)
  Optimize Logic in `selection-tools` Module (josStorer#564)
  release v2.4.6
  support for chromium side panel (josStorer#111)
  allow filling in the API Key of CustomModel mode (josStorer#561, previously designed for local offline model or custom server, now you can also use it for regular openai API calls and freely fill in the model name(josStorer#563))
  update for chatgpt3.5 web (josStorer#562, josStorer#551#issuecomment-1803668105, josStorer#543#issuecomment-1803666487)
  Added box for gh pr's and issues (josStorer#558)
  Replace legacy gpt-3.5-turbo-0613 with the latest gpt-3.5-turbo-1106
  Add OpenAI API GPT-4 Turbo Preview
  Turkish readme Translation (josStorer#553)
  chore
  firefox patch
  release v2.4.5
  update build scripts
  force scroll to bottom after submission
  docs: phrase translation according language README_IN
  improve render performance (josStorer#265)
  docs: add Japanese README
  Create .gitattributes
  improve chatgpt web user guide
  release v2.4.4
  improve chatgpt web mode compatibility
  improve chatgpt web user guide
  Add site adapters for Golem, EETimes
  release v2.4.3
  fix safari background (josStorer#512 (comment))
  improve fetchSSE (josStorer#532)
  re-order parse process
  fix: parse sse
  Make summarization work for text/plain content
  chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2
  fix josStorer#539 bing web
  blob file read for gitlab (josStorer#544)
  fix chatgpt web mode arkose_token (josStorer#469, josStorer#543, josStorer#545)
  remove BingImageCreator
  disable poe temporarily
  upgrade caniuse-lite
  remove commands permission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants