Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't break words #45

Merged
merged 2 commits into from
Mar 21, 2023
Merged

fix: don't break words #45

merged 2 commits into from
Mar 21, 2023

Conversation

victor141516
Copy link
Contributor

I encountered error #30 and #35, which are the same as what I'm experiencing. I noticed that you have added 18b7db2 to resolve them, yet I'm still experiencing broken words.

I found that removing the CSS rule resolves the issue, but I'm unsure if it would cause any other problems.

@josStorer
Copy link
Owner

Thanks for your contribution! I mistakenly marked that commit as #30, but it actually only resolves to #35, the reason I didn't use word-break earlier was to avoid too long words affecting the box width, I'll add a limit later

@josStorer josStorer merged commit 9befe11 into josStorer:master Mar 21, 2023
josStorer added a commit that referenced this pull request Apr 27, 2023
* fix: don't break words

* fix: don't break words as much as possible, but when the width is not enough, will still break

---------

Co-authored-by: josc146 <josStorer@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants