use serialize method in transform command

[danjuv]

This is small change, but the intention is to add a serialize member function that is called when transforming commands into their serialized counterparts.

The intention is when we add a meta-command we can add it as a subclass of Command and override serialize to add in the path to the wrapper script.

[joscha]

Hi,

thanks for the PR - how is the proposed serialize function (currently public) different from just overriding toString in a subclass?

The only thing I can think of is that potentially the implementations of toString and serialize would be different. Taking your example in #65 e.g. in structural output we could simplify RetryCommand('yarn', 2) to yarn [retry 2] whereas in serialize it could return yarn || yarn.

So in that sense the addition of serialize LGTM, however can we make sure that the visibility serialize is class-protected? You will most likely need to move transformCommand into the Command class as a static and maybe access it via a Symbol() in order to only make it accessible from within buldkite-graph

[joscha]

Cool, let's try and use this in #65 - once we have a working sample we can merge both together and release a new version

[joscha]

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀