This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
Remove gin dependency #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't worry about the codeql issues, marked them as false positive since what comes in here is not user-generated. |
|
Okay, thanks for the info! |
Removing it should be fine 👌 |
|
I am marking this as draft again, since I want to try if I can also write a nice testcase for this package. |
# Conflicts: # selfstream/rest.go # selfstream/selfstream.go
joschahenningsen
approved these changes
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
selfstreampackage.This safes actually a lot of dependencies and the API should hopefully not change too much in the near future.
The binary also shrinks by ~3MB.