Type definitions missing in ceil method #2526
Labels
Comments
TomToms55
changed the title
|
Thanks for reporting Tomas. Anyone able to bring the TypeScript definitions of |
|
The merged pull request referenced above definitely helps, but it regressed on the contents of AUTHORS (putting Divya Yeruva's dispreferred email address back in), did not actually address #2529 as claimed there, did not add tests for this concern in |
gwhitney
added a commit
that referenced
this issue
Apr 21, 2022
This is a sequel to #2531. Uniformizes the signatures of ceil, fix, floor, and round, and updates the TypeScript declarations to match. Adds the optional "number of places" argument to the chain versions of ceil, fix, and floor. Adds TypeScript tests for all rounding functions. Also corrects the TypeScript declaration for `bignumber()` and introduces a couple more common abbreviations for TypeScript types. Fixes the number-only implementations of floor, ceil, fix, and nthRoot to match the full implementation behavior on numbers, and tests this for floor. Includes some minor documentation updates and additional unit tests for the rounding functions. Reverts inclusion in AUTHORS of incorrect email for one contributor, that occurred in #2531. Resolves #2526. Resolves #2529.
josdejong
pushed a commit
that referenced
this issue
Apr 25, 2022
This is a sequel to #2531. Uniformizes the signatures of ceil, fix, floor, and round, and updates the TypeScript declarations to match. Adds the optional "number of places" argument to the chain versions of ceil, fix, and floor. Adds TypeScript tests for all rounding functions. Also corrects the TypeScript declaration for `bignumber()` and introduces a couple more common abbreviations for TypeScript types. Fixes the number-only implementations of floor, ceil, fix, and nthRoot to match the full implementation behavior on numbers, and tests this for floor. Includes some minor documentation updates and additional unit tests for the rounding functions. Reverts inclusion in AUTHORS of incorrect email for one contributor, that occurred in #2531. Resolves #2526. Resolves #2529.
|
Good points Glen, thanks for directly picking this up in #2539. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to Mathjs documentation math.ceil and math.floor support a second argument that is not described in the index.d.ts (eg: math.ceil(x, n) where n is the number of decimals with default value: 0).
Add in index.d.ts:
ceil(x: number, n: number): number;The text was updated successfully, but these errors were encountered: